Increase test coverage #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
===========================================
+ Coverage 21.33% 93.10% +71.76%
===========================================
Files 18 7 -11
Lines 5717 2002 -3715
===========================================
+ Hits 1220 1864 +644
+ Misses 4408 108 -4300
+ Partials 89 30 -59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reugn
reviewed
Sep 26, 2024
connection_provider.go
Outdated
Comment on lines
107
to
108
| grpcConnFactory func(hostPort *HostPort) (grpcClientConn, error) // For testing | ||
| connFactory func(conn grpcClientConn) *connection // For testing |
There was a problem hiding this comment.
I would take those out to test utilities.
There was a problem hiding this comment.
still thinking about how to best clean this up.
reugn
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.